[rebased] Update windows support to be much better #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
force-pushed
the
olivielpeau/windows-improvements-brentm5
branch
3 times, most recently
from
6f170d4
to
6b74cc8
Compare
Things changed: - Made the msi file install perMachine instead of per user - Do not allow the program to restart the system - Add checksum to verify file downloaded is who it says it is - Removed chef 11.X from test kitchen for windows because its not supported - Update specs to change the resource name - Add exception for legacy foodcritic warnings [[email protected]: Add recommendation to use `windows`<1.39.0 with Chef>=12.6]
olivielpeau
force-pushed
the
olivielpeau/windows-improvements-brentm5
branch
from
6b74cc8
to
183b0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #252 (rebased version of that PR)